Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICU] remove explicit apple deployment target flag #4459

Merged

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Feb 2, 2021

remove explicit tools.apple_deployment_target_flag

two reasons for the change:

  1. since Autotools adds apple deployement target flag conan#7862, AutoToolsBuildEnvironment calls tools.apple_deployment_target_flag on its own
  2. Feature: add os.sdk sub-settings for Apple conan#8263 adds os.sdk sub-setting, Feature: add Apple Catalyst support (as new os.subsystem) conan#8264 adds os.subsystem sub-setting, they need to be passed to the tools.apple_deployment_target_flag

Specify library name and version: ICU/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (86cf6a0f4a36e6c2e9a39955cfb2a821bc184a95)! 😊

@conan-center-bot conan-center-bot merged commit 0cc617a into conan-io:master Feb 5, 2021
@CroydonBot CroydonBot deleted the icu_apple_subsettings branch February 5, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants